Talk:Theora

Outstanding issues

I think, I've found a fix for the second issue (halt after 45 minutes) in theora_str: Replace this function in main.c:

inline Timestamp_t GetTimestamp(void)
{
	struct timeval tv;
	gettimeofday(&tv, NULL);
//	return (Timestamp_t) ((tv.tv_sec * TimestampTicks) + tv.tv_usec); // old
	return (( (Timestamp_t) tv.tv_sec * TimestampTicks) + tv.tv_usec); // fixing the 45-min overflow
	// (blow up 32 to 64 bits _before_ doing the calculations which otherwise give an overflow)
	// See glib/gtimer.h how the they handle timevals without any multiply,
	// but the small amount of time saved might not be of any concern here.
}

I just _think_ this is the bug, because I don't have a camera yet to test it. Hopefully we can order one soon. I'm really confident, that is is the right fix, because the error is obvious. The bug was a strong argument against your cameras, so I looked for it.

I post this here because I found no other place to do so and couldn't even find the theora_str files in the heck of the CVS tree.

Greetings --Cspan64 14:02, 29 September 2007 (CDT)